Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EdgeNetwork Layer #3439

Merged
merged 2 commits into from Jun 26, 2023
Merged

Add EdgeNetwork Layer #3439

merged 2 commits into from Jun 26, 2023

Conversation

riya-singh28
Copy link
Contributor

@riya-singh28 riya-singh28 commented Jun 21, 2023

Description

The EdgeNetwork Layer is a submodule designed for message passing in graph neural networks.

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@riya-singh28
Copy link
Contributor Author

image

@riya-singh28
Copy link
Contributor Author

@rbharath PR is ready for review.

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass review. Can you rebase now that the segment_sum PR is merged in and I will do a more thorough review?

Have one request for a documentation fix

docs/source/api_reference/layers.rst Show resolved Hide resolved
@riya-singh28 riya-singh28 marked this pull request as ready for review June 22, 2023 20:07
Copy link
Contributor

@ARY2260 ARY2260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @rbharath can you please give a review check

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit b5aaec6 into deepchem:master Jun 26, 2023
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants