Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Introduction_to_Bioinformatics.ipynb updated and fixed a Bug in the code #3481

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

piyushkanadje
Copy link

@piyushkanadje piyushkanadje commented Jul 14, 2023

Description

Tutorial Updated
Fix #(issue)
my_prot + my_seq
Error : Incompatible alphabets IUPACProtein() and IUPACUnambiguousDNA()
Fixed

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • [] Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • [ x] I have checked my code and corrected any misspellings

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@piyushkanadje piyushkanadje changed the title Tutorial Introduction_to_Bioinformatics.ipynb updated Tutorial Introduction_to_Bioinformatics.ipynb updated and fixed a Bug Jul 16, 2023
@piyushkanadje piyushkanadje changed the title Tutorial Introduction_to_Bioinformatics.ipynb updated and fixed a Bug Tutorial Introduction_to_Bioinformatics.ipynb updated and fixed a Bug in the code Jul 16, 2023
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks close to ready. We just need to run this colab for outputs and once that's done we should be able to merge

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and good to merge in once tests are passing

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit 1bf5342 into deepchem:master Aug 9, 2023
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants