Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3483
Update program logic in setting labels only attribute in
RDKitDescriptors
. Earlier, it wasfeatures[features != 0] = 1
. Here,features
is a list andfeatures != 0
computed whetherfeatures
is 0 or not. This isincorrect as we have to compare elements of
features
with 0 and not the list itself. The update usesnp.putmask
to mask elements and replace others with 1.Type of change
Please check the option that is related to your PR.
Checklist
project
yapf -i <modified file>
and check no errors (yapf version must be 0.32.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errorspython -m doctest <modified file>
and check no errors