Adding weighted_skip parameter to MutilayerPerceptron layer #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
vsomnath
requested changes
Jul 26, 2023
deepchem/models/tests/test_layers.py
Outdated
| @@ -703,6 +703,30 @@ def test_MultilayerPerceptron_overfit(): | |||
| assert np.allclose(output, y, atol=1e-2) | |||
|
|
|||
|
|
|||
| @pytest.mark.torch | |||
| def test_weighted_skip_MultilayerPerceptron(): | |||
There was a problem hiding this comment.
Change this to test_weighted_skip_multilayer_perceptron.
There was a problem hiding this comment.
On that note, could you also change the other tests with MultilayerPerceptron to a similar form?
There was a problem hiding this comment.
Yea sure, I will.
|
LGTM |
vsomnath
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By Adding weighted_skip parameter to MutilayerPerceptron layer, it can be used for skip connection as well. Hence, it can be used in place of ResidualBlock for Global and Local Message Passing in MXMNet Model.
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>and check no errors (yapf version must be 0.32.0)mypy -p deepchemand check no errorsflake8 <modified file> --countand check no errorspython -m doctest <modified file>and check no errors