Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grover finetuning fix on mps/cuda devices #3507

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

arunppsg
Copy link
Contributor

@arunppsg arunppsg commented Aug 3, 2023

Description

Fixes #3506

In this line,

if len(additional_features.shape) == 1:
additional_features = additional_features.view(

we need not use torch.from_numpy since additional_features is already a torch.Tensor (made here:

additional_features_tensor = torch.FloatTensor(additional_features)

Also the next line,

1, additional_features.shape[0])

is not needed since it is moved to device here:

a2a.to(self.device)), additional_features.to(self.device)

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this
    project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@arunppsg
Copy link
Contributor Author

arunppsg commented Aug 3, 2023

Note: ci failure in linting is not related to this pull request (mostly due to flake8 version update).

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arunppsg arunppsg merged commit 60d1fd3 into deepchem:master Aug 3, 2023
23 of 33 checks passed
@arunppsg arunppsg deleted the grover-patch branch October 18, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grover finetuning error on mps/cuda
2 participants