Grover finetuning fix on mps/cuda devices #3507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3506
In this line,
deepchem/deepchem/models/torch_models/grover.py
Lines 224 to 225 in 6ce8cd6
we need not use
torch.from_numpy
sinceadditional_features
is already a torch.Tensor (made here:deepchem/deepchem/utils/grover.py
Line 192 in 6ce8cd6
Also the next line,
deepchem/deepchem/models/torch_models/grover.py
Line 226 in 6ce8cd6
is not needed since it is moved to device here:
deepchem/deepchem/models/torch_models/grover.py
Line 597 in 6ce8cd6
Type of change
Please check the option that is related to your PR.
Checklist
project
yapf -i <modified file>
and check no errors (yapf version must be 0.32.0)mypy -p deepchem
and check no errorsflake8 <modified file> --count
and check no errorspython -m doctest <modified file>
and check no errors