Porting DTNNModel Class #3514
Merged
Porting DTNNModel Class #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaipranesh2
approved these changes
Aug 6, 2023
tonydavis629
approved these changes
Aug 14, 2023
rbharath
reviewed
Aug 21, 2023
| @@ -47,3 +49,33 @@ def test_dtnn(): | |||
|
|
|||
| # Check number of parameters | |||
| assert len(list(model.parameters())) == 17 | |||
|
|
|||
|
|
|||
| @pytest.mark.torch | |||
There was a problem hiding this comment.
We need save/reload/overfit tests. See https://deepchem.readthedocs.io/en/latest/development_guide/coding.html#testing-machine-learning-models
rbharath
reviewed
Aug 21, 2023
rbharath
reviewed
Aug 23, 2023
| def test_dtnn_multitask_regression_overfit(): | ||
| current_dir = os.path.dirname(os.path.abspath(__file__)) | ||
| dataset_file = os.path.join(current_dir, "assets/qm9_mini.sdf") | ||
| TASKS = ["alpha"] |
There was a problem hiding this comment.
You may need to add to another task here
There was a problem hiding this comment.
Done, Sorry about that.
rbharath
reviewed
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #(issue)
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>and check no errors (yapf version must be 0.32.0)mypy -p deepchemand check no errorsflake8 <modified file> --countand check no errorspython -m doctest <modified file>and check no errors