DFT Utilities [PR-1] [Config | Ztypes]

[GreatRSingh]

Description

Fix #(issue)

Type of change

Please check the option that is related to your PR.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
• Documentations (modification for documents)

Checklist

• My code follows the style guidelines of this project
  • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
  • Run mypy -p deepchem and check no errors
  • Run flake8 <modified file> --count and check no errors
  • Run python -m doctest <modified file> and check no errors
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New unit tests pass locally with my changes
• I have checked my code and corrected any misspellings

[shaipranesh2]

Need more clarification on the attributes and how they help in context to the task you are gonna perform. (like verbosity level can be explained further)

[shaipranesh2]

are the config variables required to be constant? Or can the user try to change them as well?

[GreatRSingh]

It looks like they used it as an overall configuration. I didn't find case of modification.

[GreatRSingh]

and I found some cases in which they have modified these.
dqc/test/benchmarks.py: config.VERBOSE = 1
and 2 more locations.

[rbharath]

Let's merge in for now, but we may need to come back later and clean this up

[shaipranesh2]

@GreatRSingh I have some questions on this PR.
I understand you are trying to specify the config for the DFT tasks. But can the config variables become parameters for the DFT function that you will write? instead of reading it in a separate file like this?

[GreatRSingh]

@GreatRSingh I have some questions on this PR. I understand you are trying to specify the config for the DFT tasks. But can the config variables become parameters for the DFT function that you will write? instead of reading it in a separate file like this?

I think they had used it as an overall limit specifier for their DFT functions. so i guess one file should be better.

[GreatRSingh]

I think I understand your thought, we should have these configurations according to our own ML Hardware system.

[rbharath]

LGTM