GANModel Porting #3601
Merged
GANModel Porting #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyasvinaya
commented
Oct 8, 2023
shreyasvinaya
commented
Oct 8, 2023
|
So presently i am using Tensorflow Keras tensors have a method The 2 tests checking for the mean of deltas are the ones failing |
rbharath
reviewed
Oct 8, 2023
deepchem/models/torch_models/gan.py
Outdated
|
|
||
| This class allows a GAN to have multiple generators and discriminators, a model | ||
| known as MIX+GAN. It is described in Arora et al., "Generalization and | ||
| Equilibrium in Generative Adversarial Nets (GANs)" (https://arxiv.org/abs/1703.00573). |
There was a problem hiding this comment.
Link also to the reference below
rbharath
reviewed
Oct 8, 2023
deepchem/models/torch_models/gan.py
Outdated
|
|
||
| Examples | ||
| -------- | ||
| <examples here> |
There was a problem hiding this comment.
Add examples here before final review
rbharath
reviewed
Oct 8, 2023
15 tasks
rbharath
reviewed
Nov 3, 2023
There was a problem hiding this comment.
@shreyasvinaya This looks pretty clean. Are we fully matching the existing TF API? How are the number?
If API is the same and numbers are comparable we can probably merge in tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Porting of GANModel to Torch
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>and check no errors (yapf version must be 0.32.0)mypy -p deepchemand check no errorsflake8 <modified file> --countand check no errorspython -m doctest <modified file>and check no errors