LinearOperator Base Class #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbharath
reviewed
Nov 8, 2023
| raise RuntimeError("super().__init__ must be executed first") | ||
|
|
||
|
|
||
| def checklinop(linop: LinearOperator) -> None: |
There was a problem hiding this comment.
This should be moved to the tests and not in the main library
rbharath
reviewed
Nov 8, 2023
| return self._is_gpn_implemented | ||
|
|
||
| # debug functions | ||
| def check(self, warn: Optional[bool] = None) -> None: |
There was a problem hiding this comment.
This should be moved to unit test
rbharath
reviewed
Nov 8, 2023
| create_graph=torch.is_grad_enabled())[0] # (*BAY, q) | ||
| return res | ||
|
|
||
| # def __check_if_implemented(self, methodname: str) -> bool: |
rbharath
reviewed
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #(issue)
Linear Operator. Contains only the main class.
Subsequent Classes for addition division multiplication will be implemented in further PRs.
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>and check no errors (yapf version must be 0.32.0)mypy -p deepchemand check no errorsflake8 <modified file> --countand check no errorspython -m doctest <modified file>and check no errors