Wgan Porting #3666
Merged
Wgan Porting #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbharath
reviewed
Nov 8, 2023
deepchem/models/torch_models/gan.py
Outdated
|
|
||
| References | ||
| ---------- | ||
| [1] Arjovsky, Martin, Soumith Chintala, and Léon Bottou. |
There was a problem hiding this comment.
Can you check this renders correctly on the docs locally? It needs to be in numpydoc style
rbharath
reviewed
Nov 8, 2023
deepchem/models/torch_models/gan.py
Outdated
| (https://arxiv.org/abs/1704.00028) | ||
| """ | ||
|
|
||
| def __init__(self, gradient_penalty=10.0, **kwargs): |
rbharath
reviewed
Nov 8, 2023
rbharath
reviewed
Nov 8, 2023
| discrim_output_gen[1]) + discrim_output_train[1] | ||
|
|
||
|
|
||
| class GradientPenaltyLayer(nn.Module): |
There was a problem hiding this comment.
More detailed docstrings and usage examples
rbharath
reviewed
Nov 8, 2023
rbharath
reviewed
Nov 8, 2023
| discrim_output_gen[1]) + discrim_output_train[1] | ||
|
|
||
|
|
||
| class GradientPenaltyLayer(nn.Module): |
There was a problem hiding this comment.
Need a unit test for this layer
rbharath
reviewed
Nov 8, 2023
deepchem/models/torch_models/gan.py
Outdated
| class GradientPenaltyLayer(nn.Module): | ||
| """Implements the gradient penalty loss term for WGANs.""" | ||
|
|
||
| def __init__(self, gan, discriminator, **kwargs): |
There was a problem hiding this comment.
Type annotations here and rest of the layer
rbharath
reviewed
Nov 8, 2023
deepchem/models/torch_models/gan.py
Outdated
| self.gan = gan | ||
| self.discriminator = discriminator | ||
|
|
||
| def forward(self, inputs, conditional_inputs): |
There was a problem hiding this comment.
Type annotations and return type
rbharath
reviewed
Nov 8, 2023
rbharath
reviewed
Nov 22, 2023
deepchem/models/torch_models/gan.py
Outdated
|
|
||
| Notes | ||
| ----- | ||
| This class is not intended to be used directly. It is used internally by |
rbharath
reviewed
Nov 22, 2023
deepchem/models/torch_models/gan.py
Outdated
| the output from the discriminator, followed by the gradient penalty. | ||
| """ | ||
| # concatenate inputs and conditional_inputs | ||
| # inputs = list(inputs) + list(conditional_inputs) |
rbharath
reviewed
Nov 22, 2023
rbharath
reviewed
Dec 1, 2023
| discrim_output_gen[1]) + discrim_output_train[1] | ||
|
|
||
|
|
||
| class GradientPenaltyLayer(nn.Module): |
There was a problem hiding this comment.
You need to add thhis layer to the docs; can do in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WGAN Porting from Tensorflow to Pytorch
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>and check no errors (yapf version must be 0.32.0)mypy -p deepchemand check no errorsflake8 <modified file> --countand check no errorspython -m doctest <modified file>and check no errors