Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attention mask for chemberta #3667

Merged
merged 6 commits into from Nov 27, 2023
Merged

Conversation

arunppsg
Copy link
Contributor

@arunppsg arunppsg commented Nov 9, 2023

Fix #3597

Summary of changes:

  • pass attention mask for mlm
  • added more user arguments for grover model

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@arunppsg
Copy link
Contributor Author

arunppsg commented Nov 9, 2023

Note: The failure in code-formatting ci is not related to changes in this pull request.

@arunppsg arunppsg force-pushed the chemberta-patch branch 4 times, most recently from ffc9f73 to 85a8e6b Compare November 16, 2023 12:54
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunppsg Can you rebase? We just fixed jax CI so we shoudl see a lot more tests passing. I will do final review after

@arunppsg
Copy link
Contributor Author

@rbharath rebased it

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arunppsg arunppsg merged commit 9ed195d into deepchem:master Nov 27, 2023
24 of 33 checks passed
@arunppsg arunppsg deleted the chemberta-patch branch November 28, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass attribute mask for chemberta model
2 participants