AddLinearOperator [Linear Operator Helper Class] #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbharath
reviewed
Nov 21, 2023
|
|
||
| # repr helper functions | ||
| def indent(s, nspace): | ||
| """give indentation of the second line and next lines |
There was a problem hiding this comment.
Please add a note this function is used to generate string representations of LinearOperator (and any other classes it is used for)
rbharath
reviewed
Nov 21, 2023
There was a problem hiding this comment.
@GreatRSingh Please rebase this PR on top of main and address open comments
GreatRSingh
force-pushed
the
lin_helper
branch
from
a6f48ec
to
baf3370
Compare
rbharath
reviewed
Nov 30, 2023
| """ | ||
|
|
||
|
|
||
| def indent(s, nspace): |
There was a problem hiding this comment.
In a future PR, please add unit tests for these utilities
rbharath
reviewed
Nov 30, 2023
| """Convert the shape to string representation. | ||
| It also nicely formats the shape to be readable. | ||
| # Helper Classes | ||
| class AddLinearOperator(LinearOperator): |
There was a problem hiding this comment.
This should be added to the documentation. Can be done in future PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #(issue)
AddLinearOperator [Linear Operator Helper Class]
Type of change
Please check the option that is related to your PR.
Checklist
yapf -i <modified file>and check no errors (yapf version must be 0.32.0)mypy -p deepchemand check no errorsflake8 <modified file> --countand check no errorspython -m doctest <modified file>and check no errors