Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 Support #3686

Merged
merged 23 commits into from
Mar 4, 2024

Conversation

shreyasvinaya
Copy link
Member

@shreyasvinaya shreyasvinaya commented Nov 23, 2023

Description

bump up python to 3.11

Changelog

  • Bump Up all tests to python 3.11
  • Remove DQC tests - DQC is being added to deepchem
  • Remove HHSuite as dependency for python 3.11

Checklist

  • Build Scripts
    • Python 3.8
    • Python 3.9
    • Python 3.10
    • Python 3.11
  • Build Core
    • Python 3.8
    • Python 3.9
    • Python 3.10
    • Python 3.11
  • Code Formatting
    • Python 3.8
    • Python 3.9
    • Python 3.10
    • Python 3.11
  • Docs
    • Python 3.8
    • Python 3.9
    • Python 3.10
    • Python 3.11
  • Unit Test
    • Python 3.8
    • Python 3.9
    • Python 3.10
    • Python 3.11
    • All Tests Passing
      • Python 3.8
      • Python 3.9
      • Python 3.10
      • Python 3.11
  • Torch
    • Python 3.8
    • Python 3.9
    • Python 3.10
    • Python 3.11
    • All Tests Passing
      • Python 3.8
      • Python 3.9
      • Python 3.10
      • Python 3.11
  • TF
    • Python 3.8
    • Python 3.9
    • Python 3.10
    • Python 3.11
    • All Tests Passing
      • Python 3.8
      • Python 3.9
      • Python 3.10
      • Python 3.11
  • Jax
    • Python 3.9
    • Python 3.10
    • Python 3.11
    • All Tests Passing
      • Python 3.9
      • Python 3.10
      • Python 3.11

@GreatRSingh
Copy link
Contributor

GreatRSingh commented Nov 25, 2023

@shreyasvinaya hey, test-dqc is failing, you can undo changes to the dqc environment if that cleans the CI a bit, because we are removing it in 1-1.5 month.

@shreyasvinaya
Copy link
Member Author

I have had to remove hhsuite as a dependency, it doesnt support python 3.11, @GreatRSingh could you please look for hhsuite alternatives or we should consider adding the functionality of that to deepchem directly

@shreyasvinaya shreyasvinaya marked this pull request as ready for review January 20, 2024 04:29
@MischaPanch
Copy link

Hi. Quick question on the status here, do you plan on merging this?

@MischaPanch
Copy link

hhsuite seems to be no longer maintained, so I guess it's not good to have it as dependency, as it's holding you back. Supporting python 3.11 is very important as no new projects would want to use older versions of python.

Since I want to use deepchem in some of my projects, I either have to downgrade to python 3.10, or to split up repositories. Both options are a pain... Let me know if I can assist you in the move to 3.11

@shreyasvinaya
Copy link
Member Author

Hi @MischaPanch,
We are currently in discussions to merge this so it will be merged in the near future

@MischaPanch
Copy link

Great, happy to hear that, thanks for the quick answer!

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit b079607 into deepchem:master Mar 4, 2024
31 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants