Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up pytorch-lightning to 2.1.2 #3687

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Bump up pytorch-lightning to 2.1.2 #3687

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a718640
bump up pytorch-lightning to 2.1.2
shreyasvinaya Nov 23, 2023
63db7f9
fix requirements.txt for docs
shreyasvinaya Nov 26, 2023
1eb23e9
fix pinning
shreyasvinaya Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ scikit-learn
sphinx>=4.0,<5.0
sphinx_rtd_theme>=1.0
tensorflow
transformers>=4.6.*
torch==1.13.1 --extra-index-url https://download.pytorch.org/whl/cpu
pytorch-lightning==1.6.5
transformers==4.34.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update transformers to track the latest dependency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a lower bound as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be bumped. Can you put up a small fix PR? I'll merge this in since it's fixed in the actual files below

torch==2.1.0 --extra-index-url https://download.pytorch.org/whl/cpu
pytorch-lightning==2.1.2
jax
dm-haiku
optax
Expand Down
2 changes: 1 addition & 1 deletion requirements/torch/env_torch.cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ dependencies:
- dgl
- torch==2.1.0+cpu
- torch-geometric
- pytorch-lightning==1.6.5
- pytorch-lightning==2.1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a lower bound >=2.1 etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

2 changes: 1 addition & 1 deletion requirements/torch/env_torch.gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ dependencies:
- dgl-cu111
- torch==2.1.0+cu113
- torch-geometric
- pytorch-lightning==1.6.5
- pytorch-lightning==2.1.2
2 changes: 1 addition & 1 deletion requirements/torch/env_torch.mac.cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ dependencies:
- -f https://data.pyg.org/whl/torch-1.12.0+cpu.html
- dgl
- torch-geometric
- pytorch-lightning==1.6.5
- pytorch-lightning==2.1.2