Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Modules fix #3725

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Missing Modules fix #3725

merged 2 commits into from
Dec 15, 2023

Conversation

GreatRSingh
Copy link
Contributor

@GreatRSingh GreatRSingh commented Dec 15, 2023

Description

Fix #(issue)

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@GreatRSingh GreatRSingh changed the title Missing import fix Missing Modules fix Dec 15, 2023
@@ -17,3 +17,4 @@
import deepchem.dock
import deepchem.molnet
import deepchem.rl
import deepchem.deep_dft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a top level module? This should not be a top level module @GreatRSingh . This needs to be moved to a sub module of dc.models

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dc.deep_dft should not be a top level module. Please use this PR to move all these files to a submodule of dc.models. In general top level modules of deepchem should not be added for new features.

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit ba21820 into deepchem:master Dec 15, 2023
24 of 33 checks passed
@GreatRSingh GreatRSingh deleted the patch-deep-dft-2 branch December 15, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants