Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cell counting Tutorial #3845

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

aaronrockmenezes
Copy link
Contributor

@aaronrockmenezes aaronrockmenezes commented Feb 21, 2024

Description

Fix #(issue)

Added Cell Counting Tutorial

  • Need to add more docs
  • Need to add citation for tutorial
  • Add link to Colab
  • Improve comments
  • Add explanation
  • Cite Molnet and BBBC
  • Linting fixes

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@aaronrockmenezes aaronrockmenezes marked this pull request as ready for review February 21, 2024 19:11
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aaronrockmenezes aaronrockmenezes marked this pull request as draft February 21, 2024 19:13
@@ -0,0 +1,503 @@
{
Copy link
Member

@rbharath rbharath Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a diagram for the CNN. More detail about the model. Make this a new section


Reply via ReviewNB

@@ -0,0 +1,570 @@
{
Copy link
Member

@rbharath rbharath Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo "\"


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aaronrockmenezes aaronrockmenezes marked this pull request as ready for review March 1, 2024 21:15
Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit 1c52e98 into deepchem:master Mar 5, 2024
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants