Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump torch cuda version to 11.8 #3917

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

shreyasvinaya
Copy link
Member

bumping up version as docker doesn't have a 11.7 version

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • My code follows the style guidelines of this project
    • Run yapf -i <modified file> and check no errors (yapf version must be 0.32.0)
    • Run mypy -p deepchem and check no errors
    • Run flake8 <modified file> --count and check no errors
    • Run python -m doctest <modified file> and check no errors
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

bumping up version as docker doesn't have a 11.7 version
@GreatRSingh
Copy link
Contributor

@shreyasvinaya why aren't we bumping it up till 12

@shreyasvinaya
Copy link
Member Author

@GreatRSingh cuda version 12 brings in a lot of changes and a lot of systems are yet to be migrated to it. So it will be better to use cuda 11.8 and put up a notice that we will be moving to cuda 12 in the near future and in the future put up a default 12.1 cuda version and maybe a 11.8 compatibility version

Copy link
Member

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbharath rbharath merged commit 1d4dbc3 into deepchem:master Mar 26, 2024
40 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants