GraphConvTensorGraph classification with multiple tasks #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have to open a P.R. for the notebook and fix the issues mentioned in #950 |
lilleswing
changed the title
lilleswing
changed the title
|
The rewriting of metrics code is taking longer than expected. I'm going to put it as a separate CR. Feel free to merge this fix in. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were Concating vs Stacking when we were classifying. I'm not 100% sure how it was working before @peastman 's cleanup but due to implementation detail weirdness it was going through. We now properly Stack before running SoftmaxCrossEntropy, and test that TensorGraphGraphConv can work with multiple tasks.