Existential Deposit for staking #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 61.15% // Head: 61.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 61.15% 61.18% +0.03%
==========================================
Files 70 70
Lines 18649 18673 +24
==========================================
+ Hits 11404 11426 +22
- Misses 7245 7247 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jerry-yu
approved these changes
Oct 9, 2022
xcaptain
reviewed
Oct 9, 2022
| @@ -1115,8 +1121,7 @@ pub mod pallet { | |||
| Err(Error::<T>::AlreadyPaired)? | |||
| } | |||
|
|
|||
| // reject a bond which is considered to be _dust_. | |||
| if value < T::Currency::minimum_balance() { | |||
| if value < <ExistentialDeposit<T>>::get() { | |||
There was a problem hiding this comment.
I think we also need to change validate and unbond, adding this condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.