-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin support for streaming packets to Kafka #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on that. Looking forward to see the final so look solution! 🙂
There is now a |
Thanks, LGTM. We need to do better job with handling errors, but it needs to be done for S3 as well, so I'd be happy to make that change for both plugins at the same time. |
There are some assumptions that I've made in this PR that probably need to be addressed before this can be marked as ready for review.
fileSize
property and a new header is added to the first packet afterfileSize
amount of data has been received. There will be more work to do if this is the behaviour that you want.