Add gRPC support #22
Merged
Add gRPC support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add agent compatible gRPC communication - Add gRPC server compatible with scope - Adapt build steps in dockerfile
shyam-dev
reviewed
Jan 6, 2022
README.md
Outdated
| @@ -70,21 +72,43 @@ Install docker and run SecretScanner on a container image using the following in | |||
| docker run -it --rm --name=deepfence-secretscanner -v $(pwd):/home/deepfence/output -v /var/run/docker.sock:/var/run/docker.sock deepfenceio/secretscanning -local /home/deepfence/src/SecretScanner/test | |||
| ``` | |||
|
|
|||
| * Or run SecretScanner as a gRPC server: | |||
| ``` | |||
| docker run -it --rm --name=deepfence-secretscanner -v $(pwd):/home/deepfence/output -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/sock:/tmp/sock deepfenceio -socket-path /tmp/sock/s.sock | |||
There was a problem hiding this comment.
I think this command should change depending on the underlying docker sock. What will be the scenario when we use containerd ?
There was a problem hiding this comment.
PR #23 addresses the issue
Replace docker calls with vessel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin-ize SecretScanner:
socket-pathoption is provided)Tests:
Used grpcurl to trigger image scan & local directory scans.
(See updated README for exact instructions)