[Server] optimize analyzer distribution agent logs

deepflowio · Mar 7, 2024 · 44eeec7 · 44eeec7
1 parent c721bbf
commit 44eeec7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/server/controller/http/service/rebalance/traffic.go b/server/controller/http/service/rebalance/traffic.go
@@ -128,10 +128,12 @@ func (r *AnalyzerInfo) RebalanceAnalyzerByTraffic(ifCheckout bool, dataDuration
 		// update counter
 		updateCounter(vtapIDToName, vTapIDToChangeInfo)
 	}
-	log.Infof("vtap rebalance result switch_total_num(%v)", response.TotalSwitchVTapNum)
-	for _, detail := range response.Details {
-		log.Infof("vtap rebalance result az(%v) ip(%v) state(%v) before_vtap_num(%v) after_vtap_num(%v), switch_vtap_num(%v) before_vtap_weight(%v) after_vtap_weight(%v)",
-			detail.AZ, detail.IP, detail.State, detail.BeforeVTapNum, detail.AfterVTapNum, detail.SwitchVTapNum, detail.BeforeVTapWeights, detail.AfterVTapWeights)
+	if response.TotalSwitchVTapNum != 0 {
+		log.Infof("vtap rebalance result switch_total_num(%v)", response.TotalSwitchVTapNum)
+		for _, detail := range response.Details {
+			log.Infof("vtap rebalance result az(%v) ip(%v) state(%v) before_vtap_num(%v) after_vtap_num(%v), switch_vtap_num(%v) before_vtap_weight(%v) after_vtap_weight(%v)",
+				detail.AZ, detail.IP, detail.State, detail.BeforeVTapNum, detail.AfterVTapNum, detail.SwitchVTapNum, detail.BeforeVTapWeights, detail.AfterVTapWeights)
+		}
 	}
 
 	return response, nil

diff --git a/server/controller/monitor/vtap/rebalance.go b/server/controller/monitor/vtap/rebalance.go
@@ -143,8 +143,9 @@ func (r *RebalanceCheck) analyzerRebalanceByTraffic(dataDuration int) {
 	}
 	if result.TotalSwitchVTapNum != 0 {
 		log.Infof("need rebalance, total switch vtap num(%d)", result.TotalSwitchVTapNum)
-		_, err := analyzerInfo.RebalanceAnalyzerByTraffic(false, dataDuration)
-		log.Errorf("fail to rebalance analyzer by data(if check: false): %v", err)
+		if _, err := analyzerInfo.RebalanceAnalyzerByTraffic(false, dataDuration); err != nil {
+			log.Errorf("fail to rebalance analyzer by data(if check: false): %v", err)
+		}
 		return
 	}
 }