Restructure Python v3 (Part 3) - Separation of Concerns #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvonthenen
changed the title
This was referenced Nov 10, 2023
SandraRodgers
previously approved these changes
Nov 12, 2023
SandraRodgers
dismissed
their stale review
The merge-base changed after approval.
dvonthenen
force-pushed
the
restructure-project-part3
branch
from
b5ba948
to
32ce63e
Compare
dvonthenen
force-pushed
the
restructure-project-part3
branch
from
32ce63e
to
82362cc
Compare
deepgram-devrel
approved these changes
Nov 15, 2023
SandraRodgers
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on this PR #156 and #172 to restructure the project. The goal is to do this in smaller chunks so the work is not finished in this PR. The PR merges to main so the PR is going to look messy until the dependent PR is merged.
Here is a clean diff in the meantime: dvonthenen:deepgram-python-sdk:restructure-project-part2...dvonthenen:deepgram-python-sdk:restructure-project-part3
Verified that all existing demos work:
examples/demo_prerecorded.py,examples/demo_live.py, andexamples/demo_manage.pyNotable changes:
deepgram/typesand varioushelper.pyfiles that didn't need to be at this global level. If an Class, functions, enum, etc was only apart ofLivetranscription, they were moved into thedeepgram/clients/livefolder. This gives you separation of concerns and you immediately know which definitions are (usually in the same folder).