Skip to content

Commit

Permalink
Downgrade Alpine to avoid a DNS issue on older mac docker installs (#…
Browse files Browse the repository at this point in the history
…1034)

Apparently in older linux kernels or docker installs (the alpine bug report isn't sure which), DNS sometimes doesn't work, and we can't build this image since github.com fails to resolve in the second line of this RUN.

In Alpine 3.12, unzip doesn't create the directory automatically, so we need to make it ahead of time.

Alpine 3.12 EOLs May 1, 2022, we should update by then, decide that we aren't concerned with older kernels (or docker installs), or pick a different image for this proxy.

alpinelinux/docker-alpine#155

See #1119 for later followup.
  • Loading branch information
niloc132 committed Aug 25, 2021
1 parent 10fc2f6 commit a7a0454
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion grpc-proxy/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
FROM docker.io/library/alpine:3.13
# Deliberately using old alpine, see issue #1034 in deephaven-core
# See also alpinelinux/docker-alpine#155
FROM docker.io/library/alpine:3.12

COPY contents/ .

ENV GRPCWEBPROXY_VERSION=v0.13.0

# Note(deephaven-core#599): Consider moving grpcwebproxy DL into gradle
RUN set -eux; \
mkdir /app; \
apk add --no-cache tini; \
wget -q "https://github.com/improbable-eng/grpc-web/releases/download/${GRPCWEBPROXY_VERSION}/grpcwebproxy-${GRPCWEBPROXY_VERSION}-linux-x86_64.zip"; \
sha256sum -c checksums.txt; \
Expand Down

0 comments on commit a7a0454

Please sign in to comment.