Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base+ images to repo and info to README #1803

Merged
merged 4 commits into from Jan 18, 2022

Conversation

jjbrosnan
Copy link
Contributor

Will require updates to the docs repo.

@jjbrosnan jjbrosnan added documentation Improvements or additions to documentation python docker NoDocumentationNeeded labels Jan 5, 2022
@jjbrosnan jjbrosnan added this to the Jan 2022 milestone Jan 5, 2022
@jjbrosnan jjbrosnan self-assigned this Jan 5, 2022
margaretkennedy
margaretkennedy previously approved these changes Jan 5, 2022
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to, at a very minimum, have a testing script we run through with each of the compose compositions to make sure it all works. As it stands, I think a large number of them will not work.

In addition, I think we should try and work towards a new strategy instead of having the matrix of python packages and examples/no-examples. We can work to parameterize these compose definitions in the future (using environment variables, or .env files), and it may reduce complexity.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
containers/python-examples/PyTorch/docker-compose.yml Outdated Show resolved Hide resolved
containers/python-examples/NLTK/docker-compose.yml Outdated Show resolved Hide resolved
containers/python/NLTK/docker-compose.yml Outdated Show resolved Hide resolved
containers/python/NLTK/docker-compose.yml Outdated Show resolved Hide resolved
containers/python/PyTorch/docker-compose.yml Outdated Show resolved Hide resolved
containers/python/SciKit-Learn/docker-compose.yml Outdated Show resolved Hide resolved
containers/python/TensorFlow/docker-compose.yml Outdated Show resolved Hide resolved
@jjbrosnan
Copy link
Contributor Author

I have tested every docker-compose file in this PR. They all work. There is one thing to note:

The two NLTK images cause warnings in the web console when starting up Deephaven because a couple of other Python packages aren't installed: tkinter and one other.

@jjbrosnan jjbrosnan merged commit 0da085c into deephaven:main Jan 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
@jjbrosnan jjbrosnan deleted the update_readme_baseplus branch August 1, 2023 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docker documentation Improvements or additions to documentation NoDocumentationNeeded python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants