Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 'x == null' differently to avoid ambiguous eq overloads. #1931

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Handle 'x == null' differently to avoid ambiguous eq overloads. #1931

merged 3 commits into from
Feb 3, 2022

Conversation

jcferretti
Copy link
Member

Fixes #1925.

@jcferretti jcferretti added this to the Feb 2022 milestone Feb 2, 2022
@jcferretti jcferretti self-assigned this Feb 2, 2022
@jcferretti
Copy link
Member Author

Ran locally the nightly gradle targets, they pass.

cpwright
cpwright previously approved these changes Feb 2, 2022
View reviewed changes
kosak
kosak previously approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@kosak kosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some day someone needs to take a stern look at this whole file and do it more elegantly.

But, I believe your changes are correct (please see my comments).

engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java Show resolved Hide resolved
@jcferretti jcferretti dismissed stale reviews from kosak and cpwright via 0a0f2e3 February 3, 2022 00:27
kosak
kosak previously approved these changes Feb 3, 2022
View reviewed changes
@jcferretti jcferretti merged commit a629eb3 into deephaven:main Feb 3, 2022
@jcferretti jcferretti deleted the cfs-parser-eq-null-0 branch February 3, 2022 04:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kosak kosak kosak approved these changes

@cpwright cpwright cpwright left review comments

Assignees

@jcferretti jcferretti

Labels
NoDocumentationNeeded
Projects
None yet
Milestone
Feb 2022
Development

Successfully merging this pull request may close these issues.

Nightly CI unit test failure due to formula ambiguity
3 participants
@jcferretti @kosak @cpwright