Hand-wrap TableReplayer/DynamicTableWriter/TableLoggers, fixes #1944 #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Feb 9, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/util/DynamicTableWriter.java
Show resolved
Hide resolved
rcaudy
reviewed
Feb 10, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/util/DynamicTableWriter.java
Outdated
Show resolved
Hide resolved
jmao-denver
force-pushed
the
feature-1944
branch
from
858cd42
to
da0bf74
Compare
chipkent
requested changes
Feb 16, 2022
engine/table/src/main/java/io/deephaven/engine/table/impl/util/DynamicTableWriter.java
Show resolved
Hide resolved
jmao-denver
requested review from
rcaudy,
devinrsmith,
chipkent and
cpwright
devinrsmith
previously requested changes
Feb 17, 2022
jmao-denver
force-pushed
the
feature-1944
branch
2 times, most recently
from
3c0b551
to
15b9b29
Compare
devinrsmith
reviewed
Feb 18, 2022
jmao-denver
force-pushed
the
feature-1944
branch
from
e170b68
to
eca12a8
Compare
chipkent
requested changes
Feb 22, 2022
py/jpy-integration/src/javaToPython/java/io/deephaven/jpy/integration/MyNumbersBoxed.java
Show resolved
Hide resolved
py/jpy-integration/src/javaToPython/java/io/deephaven/jpy/integration/MyNumbersNumber.java
Show resolved
Hide resolved
py/jpy-integration/src/javaToPython/java/io/deephaven/jpy/integration/MyNumbersObject.java
Show resolved
Hide resolved
py/jpy-integration/src/javaToPython/java/io/deephaven/jpy/integration/MyNumbersPrimitive.java
Show resolved
Hide resolved
py/jpy-integration/src/javaToPython/python/io/deephaven/jpy/integration/my_numbers.py
Show resolved
Hide resolved
py/jpy-integration/src/javaToPython/java/io/deephaven/jpy/integration/PyLibTest.java
Show resolved
Hide resolved
devinrsmith
reviewed
Feb 22, 2022
engine/table/src/main/java/io/deephaven/engine/util/PythonScopeJpyImpl.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/util/DynamicTableWriter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/util/DynamicTableWriter.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/util/DynamicTableWriter.java
Outdated
Show resolved
Hide resolved
Also made TableLogger Pep8 compliant and renamed it to perfmon
Given the choice, users will be drawn to use the convenience methods logRow() in DynamicTableWriter which accept generic java.lang.Object in the input parameters. So there is a chance the numeric values don't match the declared Column data type are passed in. As performance isn't really a big concern here, we can afford to perform conversions and make it easier for the users than require them to do cast/conversion before calling the methods.
The PermissiveRowSetter extends RowSetter with an addtional method that allows unsafe numeric conversion. The setPermissive() is only called by logRow() convenience overloads which are only used by the Python API.
Added the functions in those modules to perfmon Todo: consult Cristian to ensure the docs are accurate and clear and also get answers about the need of some of the functions in DHC
jmao-denver
force-pushed
the
feature-1944
branch
from
00dc6db
to
07e0efe
Compare
chipkent
requested changes
Feb 23, 2022
chipkent
requested changes
Feb 28, 2022
pyintegration/deephaven2/replay.py
Outdated
Comment on lines
78
to
76
| self._j_replayer.shutdown() | ||
| self._hist_tables = [] |
There was a problem hiding this comment.
Shouldn't the shutdown call still be here, but the self._hist_tables be gone?
chipkent
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1944 #2004 #1730