Arrays of tables/tablemaps should be sized correctly #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the JS Figure will not close correctly, though other operations are not affected by this. Fixes deephaven#1951
mofojed
approved these changes
Feb 8, 2022
| @@ -657,7 +656,7 @@ public Promise fetch(JsFigure figure, FetchObjectResponse response) { | |||
| JsTable table = new JsTable(connection, cts); | |||
| // never attempt a reconnect, since we might have a different figure schema entirely | |||
| table.addEventListener(JsTable.EVENT_DISCONNECT, ignore -> table.close()); | |||
| tables[p1] = table; | |||
| tables[tables.length] = table; | |||
There was a problem hiding this comment.
Ah the beauty of JS
Couldn't we just do the same with the promises as well?
There was a problem hiding this comment.
Could, but no need, since we know it will be sized to the full width.
I could make this more "correct in java" and count how many are tables... but it is js, so I didn't (but for a reviewer who asks for it, i will).
mattrunyon
approved these changes
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the JS Figure will not close correctly, though other
operations are not affected by this.
Fixes #1951