Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of .env content; Add debezium/perf. #1970

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

jcferretti
Copy link
Member

@jcferretti jcferretti commented Feb 12, 2022

On .env files:

  • Remove unused definitions.
  • Rename PORT to DEEPHAVEN_PORT; since environment variables override, it is desirable to have something more specific to avoid somebody's personal environment definitions mixing things for them.

Simplify memory configuration for the server definition in docker-compose-common.yml.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the assumption you'd be removing our docker deploy resource limits - was that going to be separate?

I do want to take the time Monday and run the compose file myself.

.env Outdated Show resolved Hide resolved
@jcferretti
Copy link
Member Author

I was under the assumption you'd be removing our docker deploy resource limits - was that going to be separate?

I do want to take the time Monday and run the compose file myself.

Somehow I lost that change; done.

Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give @niloc132 a chance; and I still want to take a pass at running it soon.

@jcferretti jcferretti merged commit e51a723 into deephaven:main Feb 14, 2022
@jcferretti jcferretti deleted the cfs-debezium-perf-1 branch February 14, 2022 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2022

mysql:
image: debezium/example-mysql:1.4
ports:
- 3306:3306
- 3306:3306
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the fact review: prefer quotes for these (like you did in line 49) since yaml can do some super awesome type coercion when it doesn't know what you might be trying to express

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants