Incrementally rehash for incremental aggregations, use a specialized index builder for modifications. #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f60fe3f.
cpwright
commented
Feb 23, 2022
rcaudy
reviewed
Feb 24, 2022
...eephaven/engine/table/impl/by/OperatorAggregationStateManagerOpenAddressedAlternateBase.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Feb 24, 2022
...io/deephaven/engine/table/impl/by/typed/incopenagg/gen/IncrementalAggOpenHasherByteChar.java
Outdated
Show resolved
Hide resolved
cpwright
commented
Feb 25, 2022
rcaudy
reviewed
Feb 25, 2022
| @@ -131,6 +135,15 @@ public void onNextChunk(int size) { | |||
| return keyHashTableSources; | |||
| } | |||
|
|
|||
| @Override | |||
| public void beginUpdateCycle() { | |||
| // at the beginning of the update cycle, we always want to do some rehash work so that we can eventually ditch | |||
There was a problem hiding this comment.
This is only going to fire if the parent changes. That said, I think this is good enough; not worth pushing for something external on the cycle to force changes.
...eephaven/engine/table/impl/by/OperatorAggregationStateManagerOpenAddressedAlternateBase.java
Outdated
Show resolved
Hide resolved
...eephaven/engine/table/impl/by/OperatorAggregationStateManagerOpenAddressedAlternateBase.java
Outdated
Show resolved
Hide resolved
…peratorAggregationStateManagerOpenAddressedAlternateBase.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
…peratorAggregationStateManagerOpenAddressedAlternateBase.java Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
rcaudy
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.