Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstructSnapshot + BarrageMessageProducer: Use Static ConstructSnapshot Fast Path #4876

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

nbauernfeind
Copy link
Member

This fixes the following query:

def static_right = emptyTable(1).update("Test = `test`")
Thread.start {
    result = emptyTable(1000).join(static_right)
}.join()

The result table is a static table built without an ExecutionContext, as should be allowed.

However, the captured update graph is the PoisonedUpdateGraph which throws in ConstructSnapshot. While ConstructSnapshot allows for a null UpdateGraph, the SnapshotControl does not "go through the motions" of an otherwise typical snapshot.

Conveniently, this fix will snapshot static tables (even those that capture a valid UpdateGraph) to work their way through ConstructSnapshot with less hassle, no locks, and no unnecessary retries.

@nbauernfeind nbauernfeind added bug Something isn't working barrage core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Nov 21, 2023
@nbauernfeind nbauernfeind added this to the November 2023 milestone Nov 21, 2023
@nbauernfeind nbauernfeind self-assigned this Nov 21, 2023
@nbauernfeind nbauernfeind changed the title ConstructSnapshot + BarrageMessageProducer: Use Static ConstructSnapshot Shortcut ConstructSnapshot + BarrageMessageProducer: Use Static ConstructSnapshot Fast Path Nov 21, 2023
@nbauernfeind nbauernfeind merged commit eab615f into deephaven:main Nov 22, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
barrage bug Something isn't working core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants