fix: Use correct schema when opening transformed partitioned tables #5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Mar 28, 2024
mofojed
commented
- We were using the schema from the constituent table when trying to reference the key columns instead of the keys table
- Was not a problem when the schemas matched, but if there was a transform on the table removing one of the key columns, it would throw an error
- Fixes JsPartitionedTable breaks if raw partitioned table schema does not match the constituent tables #5304
- Tested using the snippet in the ticket
- We were using the schema from the constituent table when trying to reference the key columns instead of the keys table - Was not a problem when the schemas matched, but if there was a transform on the table removing one of the key columns, it would throw an error - Fixes deephaven#5304
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
niloc132
previously approved these changes
Mar 28, 2024
- Just tests for static JsPartitionedTable for now
niloc132
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.