Bidirectional Communication #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
reviewed
Jul 31, 2023
| @@ -28,35 +28,128 @@ class Exporter(abc.ABC): | |||
|
|
|||
| @abc.abstractmethod | |||
| def reference( | |||
| self, object, allow_unknown_type: bool = False, force_new: bool = False | |||
| self, obj: object, allow_unknown_type: bool = False, force_new: bool = False | |||
There was a problem hiding this comment.
Suggested change
| self, obj: object, allow_unknown_type: bool = False, force_new: bool = False | |
| self, obj: Any, allow_unknown_type: bool = False, force_new: bool = False |
|
@mattrunyon worked me through the changes which mostly make sense. But I was having a hard time imaging how an user would be able to create a custom plugin on his own with the limited documentation. Maybe we can direct them to https://github.com/deephaven/deephaven-core/tree/779787bd9b374434290e7d47769d84e0c507d36d/py/server/deephaven/pandasplugin for a working example. But overall I find the naming in the API to be a bit confusing and the explanations of the purpose of many methods and the relationship between the classes not very helpful. |
|
Superseded by #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augments
ObjectTypeto support bidirectional communication. Adds a newBidiObjectBasewhich objects that a plugin handles can extend if they wish to support bidi communication.Needs deephaven/deephaven-core#4086 to work properly