Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Read file separator from server config #2118

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jun 28, 2024

BREAKING CHANGE: Implementations of FileStorage must now provide the readonly separator: string property

- Forgot to pass the separator in when creating a storage table
@mofojed mofojed requested a review from niloc132 June 28, 2024 14:12
@mofojed mofojed self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 48.34437% with 78 lines in your changes missing coverage. Please review.

Project coverage is 46.48%. Comparing base (e75e716) to head (e69d64a).
Report is 9 commits behind head on main.

Files Patch % Lines
packages/file-explorer/src/NewItemModal.tsx 0.00% 23 Missing ⚠️
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 0.00% 20 Missing ⚠️
packages/file-explorer/src/FileExplorer.tsx 61.11% 6 Missing and 1 partial ⚠️
packages/code-studio/src/main/AppInit.tsx 0.00% 6 Missing ⚠️
...kages/dashboard-core-plugins/src/ConsolePlugin.tsx 16.66% 5 Missing ⚠️
...ages/app-utils/src/storage/grpc/GrpcFileStorage.ts 0.00% 4 Missing ⚠️
...es/app-utils/src/storage/grpc/GrpcLayoutStorage.ts 0.00% 4 Missing ⚠️
packages/file-explorer/src/FileList.tsx 25.00% 3 Missing ⚠️
...app-utils/src/storage/grpc/GrpcFileStorageTable.ts 66.66% 2 Missing ⚠️
packages/file-explorer/src/useFileStorage.ts 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
- Coverage   46.64%   46.48%   -0.17%     
==========================================
  Files         679      685       +6     
  Lines       38632    38487     -145     
  Branches     9792     9590     -202     
==========================================
- Hits        18020    17890     -130     
- Misses      20560    20586      +26     
+ Partials       52       11      -41     
Flag Coverage Δ
unit 46.48% <48.34%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Added a context to pass down the FileStorage and file separator
- Cleaned up all the types and the tests
@mofojed mofojed requested a review from mattrunyon July 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat files as opaque strings to support different file systems
1 participant