Mxnet should not be mandatory for the python package #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will update it to PyPI soon. |
|
pip 0.4.1 updated. |
theparitt
pushed a commit
to theparitt/insightface
that referenced
this pull request
Apr 4, 2024
Mxnet should not be mandatory for the python package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the structure of the imports requires mxnet to be installed. However mxnet is not the default backend for running inference, thus should not be required to be installed when using the package for inference.
Changing the import structure does not require mxnet to be installed now when running the FaceAnalysis