Fix a bug in face_align.py #816
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi. I'm Lee First of all, thank you for your great works! It's very helpful to me. I found a bug in face_align.py. https://github.com/deepinsight/insightface/blob/be3f7b3e0e635b56d903d845640b048247c41c90/common/face_align.py#L68 when i select `mode=='arcface'` and exec `tform.estimate(lmk, src[i])`, ValueError is occur because shape of `src` is not like (1, 5, 2) but just (5, 2). ``` ValueError: shapes (2,) and (5,2) not aligned: 2 (dim 0) != 5 (dim 0) ``` so i modified the line that get into trouble provisionally. (just make it np.array form) thank you
anxiangsir
force-pushed
the
master
branch
5 times, most recently
from
e391616
to
760d6de
Compare
anxiangsir
force-pushed
the
master
branch
10 times, most recently
from
3c5e7bc
to
fa9afd0
Compare
anxiangsir
force-pushed
the
master
branch
11 times, most recently
from
15bda16
to
88b0739
Compare
anxiangsir
force-pushed
the
master
branch
2 times, most recently
from
5f1c233
to
e1300d3
Compare
anxiangsir
force-pushed
the
master
branch
6 times, most recently
from
c982e3c
to
9ff1f80
Compare
anxiangsir
force-pushed
the
master
branch
5 times, most recently
from
93e2886
to
d9cb10e
Compare
anxiangsir
force-pushed
the
master
branch
3 times, most recently
from
44bfb51
to
92c6bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'm Lee
First of all, thank you for your great works! It's very helpful to me.
I found a bug in face_align.py.
insightface/common/face_align.py
Line 68 in be3f7b3
when i set
mode=='arcface', ValueError is occur intform.estimate(lmk, src[i])because the shape ofsrcis not(1, 5, 2)(maybe expected) but just(5, 2).so i modified the line that get into trouble provisionally. (just make it np.array form)
thank you