Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lora model id in correctness test #1263

Merged
merged 1 commit into from
Nov 3, 2023
Merged

update lora model id in correctness test #1263

merged 1 commit into from
Nov 3, 2023

Conversation

rohithkrn
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@rohithkrn rohithkrn requested review from zachgk, frankfliu and a team as code owners November 3, 2023 19:09
@rohithkrn rohithkrn merged commit a6fa50e into deepjavalibrary:master Nov 3, 2023
5 of 8 checks passed
zachgk added a commit to zachgk/djl-demo that referenced this pull request Nov 6, 2023
@zachgk
Update lora notebook with working model id
76c1d45 
Follows deepjavalibrary/djl-serving#1263
@zachgk zachgk mentioned this pull request Nov 6, 2023
Merged
zachgk added a commit to deepjavalibrary/djl-demo that referenced this pull request Nov 8, 2023
@zachgk
Update lora notebook with working model id (#384)
0e685a8 
Follows deepjavalibrary/djl-serving#1263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaquib maaquib maaquib approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu frankfliu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohithkrn @maaquib