Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Workaround bug in PublisherBytesSupplier #1277

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[python] Workaround bug in PublisherBytesSupplier #1277

merged 1 commit into from
Nov 7, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners November 6, 2023 22:41
zachgk
zachgk reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the bug?

@frankfliu
Copy link
Contributor Author

What is the bug?

The new changes in PublisherBytesSupplier causing hang in certain condition(DeepSpeed streaming). Didn't debug yet.

@frankfliu frankfliu merged commit 9425ee2 into deepjavalibrary:master Nov 7, 2023
7 checks passed
@frankfliu frankfliu deleted the bug branch November 7, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maaquib maaquib maaquib approved these changes

@zachgk zachgk zachgk approved these changes

@sindhuvahinis sindhuvahinis sindhuvahinis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frankfliu @maaquib @zachgk @sindhuvahinis