Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnitTest] adding more properties testing #1306

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[UnitTest] adding more properties testing #1306

merged 1 commit into from
Nov 10, 2023

Conversation

sindhuvahinis
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

sindhuvahinis
sindhuvahinis commented Nov 9, 2023
View reviewed changes
engines/python/setup/djl_python/tests/test_properties_manager.py
"low_cpu_mem_usage":
"true",
'context_length_estimate':
'{"context_length": "128", "variable_size": "12"}'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tosterberg Added temp context_length_estimate for testing whether we are parsing the properties.

@lanking520 lanking520 merged commit 14a6b45 into deepjavalibrary:master Nov 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosterberg tosterberg tosterberg approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu frankfliu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sindhuvahinis @tosterberg @lanking520