[DeepSpeed] Fix datatype and allow checkpoint loading #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddvenk
reviewed
Dec 7, 2022
| @@ -95,11 +95,11 @@ | |||
|
|
|||
|
|
|||
| def get_torch_dtype_from_str(dtype: str): | |||
There was a problem hiding this comment.
Do we want to include something like this https://github.com/microsoft/DeepSpeed-MII/blob/main/mii/config.py#L7?
Or do we need to add documentation about what the supported dtype strings are in serving.properties?
frankfliu
reviewed
Dec 7, 2022
siddvenk
reviewed
Dec 7, 2022
frankfliu
reviewed
Dec 7, 2022
| @@ -140,11 +139,10 @@ def _parse_properties(self, properties): | |||
| self.model_dir = properties.get("model_dir") | |||
| self.model_id = properties.get("model_id") | |||
| self.task = properties.get("task") | |||
| self.data_type = get_torch_dtype_from_str(properties.get("data_type", "fp32")) | |||
| self.data_type = get_torch_dtype_from_str(properties.get("dtype", "fp16")) | |||
There was a problem hiding this comment.
fp16 works better and better range of supported model on DeepSpeed. model like Bloom is not working on fp32
There was a problem hiding this comment.
I mean as a normal user, they will assume fp32 is default. They only override it to fp16 intentionally
There was a problem hiding this comment.
most LLM saved on huggingface is under fp16
frankfliu
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a few fixes on data type and checkpoint loading settings