Update sd handler to return image in request, fix some default values… #377

siddvenk · 2022-12-10T00:41:44Z

Please do not merge until I have run the new tests against the changes here

Updates stable diffusion handler to return content-type image/png to user so client can receive image
Change some default values from None to empty version of corresponding data type (causes issues in generate if None)
Add test for stable-diffusion-v1-4 model

engines/python/setup/djl_python/stable-diffusion.py

tests/integration/llm/prepare.py

tests/integration/llm/client.py

…, add stable diffusion testing

lanking520 · 2022-12-10T20:05:48Z

Merge it for now, let's fix it in the next PR

siddvenk requested review from zachgk and frankfliu as code owners December 10, 2022 00:41

frankfliu approved these changes Dec 10, 2022

View reviewed changes

engines/python/setup/djl_python/stable-diffusion.py Outdated Show resolved Hide resolved

lanking520 approved these changes Dec 10, 2022

View reviewed changes

tests/integration/llm/prepare.py Outdated Show resolved Hide resolved

tests/integration/llm/client.py Show resolved Hide resolved

siddvenk force-pushed the ds-stable-diffusion branch 3 times, most recently from e42f922 to 2811a7d Compare December 10, 2022 02:12

Update sd handler to return image in request, fix some default values…

28d974d

…, add stable diffusion testing

siddvenk force-pushed the ds-stable-diffusion branch from 2811a7d to 28d974d Compare December 10, 2022 02:33

reformat python code

af37b07

lanking520 merged commit 656f31b into master Dec 10, 2022

lanking520 deleted the ds-stable-diffusion branch December 10, 2022 20:05