Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] Adds non-root user to docker #378

Merged
merged 1 commit into from
Dec 10, 2022
Merged

[docker] Adds non-root user to docker #378

merged 1 commit into from
Dec 10, 2022

Conversation

frankfliu
Copy link
Contributor

Allows user run DJL docker image as non-root user

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu
[docker] Adds non-root user to docker
811faa2 
Allows user run DJL docker image as non-root user
@lanking520
Copy link
Member

Is that okay if the work directory is different? WORKDIR /opt/djl

@frankfliu
Copy link
Contributor Author

frankfliu commented Dec 10, 2022 •
edited
Loading

User's home directory has nothing to do with working directory
And we are not running as djl by default

@frankfliu frankfliu merged commit 949de9f into deepjavalibrary:master Dec 10, 2022
@frankfliu frankfliu deleted the user branch December 10, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frankfliu @lanking520