Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded version in Assertion error #789

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Remove hardcoded version in Assertion error #789

merged 1 commit into from
Jun 1, 2023

Conversation

sindhuvahinis
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners June 1, 2023 00:30
@sindhuvahinis sindhuvahinis merged commit 026e557 into deepjavalibrary:master Jun 1, 2023
8 checks passed
@sindhuvahinis sindhuvahinis deleted the version_str branch June 13, 2023 00:08
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@sindhuvahinis
Remove hardcoded version (deepjavalibrary#789)
b1bce07
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@sindhuvahinis @KexinFeng
Remove hardcoded version (deepjavalibrary#789)
f2d7808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankfliu frankfliu frankfliu approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sindhuvahinis @frankfliu