[Fix] [CI/CD] Check if input is empty #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
approved these changes
Jun 2, 2023
frankfliu
reviewed
Jun 2, 2023
frankfliu
approved these changes
Jun 2, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
* [Fix] [CI/CD] Check if input is empty
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
* [Fix] [CI/CD] Check if input is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scheduler does not have the options to get inputs. Inputs are only seems to be available in worflow_dispatch.
So, made the default value of run_test to be empty. Even if input is not even provided, github seems to set the input param name empty by default.
Testing:
I removed the whole run_test input for yaml and ran the workflow, github.event.inputs.run_test env variable is validated to be empty. So the tests were not skipped.
https://github.com/deepjavalibrary/djl-serving/actions/runs/5158317906