fix typo in sm workflow inputs #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindhuvahinis
approved these changes
Jun 6, 2023
lanking520
reviewed
Jun 6, 2023
| @@ -6,7 +6,7 @@ on: | |||
| mode: | |||
| description: "release/nightly containers to test. Default is nightly" | |||
| required: false | |||
| default: nightly | |||
| default: 'nightly' | |||
There was a problem hiding this comment.
the true default will be empty (if triggered by scheduler) please make sure you have this checked in the script.
There was a problem hiding this comment.
that's the issue then. I didn't know that before, thanks for sharing. I've updated the workflow accordingly
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typo in default value of mode was causing issues starting the python script. This should fix that, I kicked off a run here with the changes and it seems to be working so far https://github.com/deepjavalibrary/djl-serving/actions/runs/5191566105