Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training as listener #39

Closed
jSaso opened this issue Mar 19, 2020 · 3 comments
Closed

Training as listener #39

jSaso opened this issue Mar 19, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jSaso
Copy link

jSaso commented Mar 19, 2020

Description

Implement training as listener, so we can subscribe to training listener. We need more information to each of the provided listeners:

  • normalize/de-normalize class (separate feature request)
  • train data set
  • test data set
  • last best model
  • last best model score

In this way we can do whatever we want:

  • calculate prediction from best model data set with our test data set,
  • de-normalize test data set and compare with de-normalized predicted data set
  • create our own evaluation with real vs. predicted data
  • create evaluation on train data
  • create evaluation on test data
  • on complete we want latest best model (with best score), the sam onEpoch listener
  • on completion listener we can save training model for later use - transfer learning
  • combined with early stop configuration - so we can check which termination condition stop training (separate feature request)

Will this change the current api? How?

Yes, training should be implemented as listener, so we can subscribe to listener.
Interface should have:
onStart
onEpoch
onCompletion

Who will benefit from this feature?

Everybody, subscribe to the listener and we have all information we need

References

Reference implementation: https://github.com/eclipse/deeplearning4j/blob/b5f0ec072f3fd0da566e32f82c0e43ca36553f39/deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/earlystopping/listener/EarlyStoppingListener.java
but we need more information inside each of onStart, onEpoch and onCompletion method - see above

@keerthanvasist
Copy link
Contributor

Thank you for creating this issue @jSaso.

@keerthanvasist keerthanvasist added the enhancement New feature or request label Mar 20, 2020
@zachgk
Copy link
Contributor

zachgk commented Mar 23, 2020

@jSaso We have a TrainingListener class that was added in 0.3.0. Does this look like it will work or do you see any issues with it?

@zachgk
Copy link
Contributor

zachgk commented Jun 12, 2020

Since we have this feature and there is no response, I will close the issue for now. Please feel free to reopen or open a new issue

@zachgk zachgk closed this as completed Jun 12, 2020
aksrajvanshi added a commit to aksrajvanshi/djl that referenced this issue Mar 18, 2021
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants