Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fixes NDArrayAdapter toDevice() and toType() behavior #1839

Merged
merged 1 commit into from Jul 26, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: Iaf90c609a832f3f7bc2a863bdb44cfc7df34dbae

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: Iaf90c609a832f3f7bc2a863bdb44cfc7df34dbae
@frankfliu frankfliu requested a review from zachgk as a code owner July 26, 2022 16:57
@codecov-commenter
Copy link

Codecov Report

Merging #1839 (d1e58e3) into master (bb5073f) will decrease coverage by 2.37%.
The diff coverage is 64.45%.

@@             Coverage Diff              @@
##             master    #1839      +/-   ##
============================================
- Coverage     72.08%   69.71%   -2.38%     
- Complexity     5126     5524     +398     
============================================
  Files           473      526      +53     
  Lines         21970    24431    +2461     
  Branches       2351     2662     +311     
============================================
+ Hits          15838    17033    +1195     
- Misses         4925     6087    +1162     
- Partials       1207     1311     +104     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
.../cv/translator/StyleTransferTranslatorFactory.java 40.00% <ø> (ø)
... and 420 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404c733...d1e58e3. Read the comment docs.

@frankfliu frankfliu merged commit 2763699 into deepjavalibrary:master Jul 26, 2022
@frankfliu frankfliu deleted the nd branch July 26, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants