Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Set arguments in serving.properties as model properties #1853

Merged
merged 1 commit into from Aug 2, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: I777e04d723afd0edf0dc7227ac6b6abf933a9d81

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I777e04d723afd0edf0dc7227ac6b6abf933a9d81
@frankfliu frankfliu requested a review from zachgk as a code owner August 2, 2022 00:48
@codecov-commenter
Copy link

Codecov Report

Merging #1853 (f92ef2c) into master (bb5073f) will decrease coverage by 2.31%.
The diff coverage is 64.64%.

@@             Coverage Diff              @@
##             master    #1853      +/-   ##
============================================
- Coverage     72.08%   69.76%   -2.32%     
- Complexity     5126     5536     +410     
============================================
  Files           473      526      +53     
  Lines         21970    24459    +2489     
  Branches       2351     2666     +315     
============================================
+ Hits          15838    17065    +1227     
- Misses         4925     6084    +1159     
- Partials       1207     1310     +103     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
.../cv/translator/StyleTransferTranslatorFactory.java 40.00% <ø> (ø)
... and 421 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1197b...f92ef2c. Read the comment docs.

@frankfliu frankfliu merged commit f1ebbe8 into deepjavalibrary:master Aug 2, 2022
@frankfliu frankfliu deleted the model branch August 2, 2022 02:55
patins1 pushed a commit to patins1/djl that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants