[api] Adds NDArray normalize() operator #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I877cd924ecada008a53b852092dc224fa1cfa70b
stu1130
approved these changes
Aug 17, 2022
| JNIEnv* env, jobject jthis, jlong jinput, jdouble jp, jlong jdim, jdouble jeps) { | ||
| API_BEGIN() | ||
| #if defined(__ANDROID__) | ||
| env->ThrowNew(ENGINE_EXCEPTION_CLASS, "Normalize is not supported on Android."); |
There was a problem hiding this comment.
android doesn't support this op?
There was a problem hiding this comment.
I actually didn't try, android doesn't support LayerNorm, and they are defined in the same file, I assume this is not supported. Will try when upgrading android to 1.12.1.
Codecov Report
@@ Coverage Diff @@
## master #1924 +/- ##
============================================
- Coverage 72.08% 69.76% -2.32%
- Complexity 5126 5683 +557
============================================
Files 473 543 +70
Lines 21970 25081 +3111
Branches 2351 2713 +362
============================================
+ Hits 15838 17499 +1661
- Misses 4925 6250 +1325
- Partials 1207 1332 +125
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
patins1
pushed a commit
to patins1/djl
that referenced
this pull request
Aug 26, 2022
Change-Id: I877cd924ecada008a53b852092dc224fa1cfa70b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I877cd924ecada008a53b852092dc224fa1cfa70b
Description
Brief description of what this PR is about