Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Remove unnecessary DeviceType interface #1978

Merged
merged 1 commit into from Aug 31, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: Ife754d8b82371c1cd86d8201d003fe8f7995ed92

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: Ife754d8b82371c1cd86d8201d003fe8f7995ed92
@frankfliu frankfliu requested a review from zachgk as a code owner August 31, 2022 03:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #1978 (22a0d12) into master (bb5073f) will decrease coverage by 1.96%.
The diff coverage is 68.47%.

@@             Coverage Diff              @@
##             master    #1978      +/-   ##
============================================
- Coverage     72.08%   70.12%   -1.97%     
- Complexity     5126     5861     +735     
============================================
  Files           473      579     +106     
  Lines         21970    25957    +3987     
  Branches       2351     2795     +444     
============================================
+ Hits          15838    18203    +2365     
- Misses         4925     6381    +1456     
- Partials       1207     1373     +166     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
.../cv/translator/StyleTransferTranslatorFactory.java 40.00% <ø> (ø)
... and 485 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lanking520 lanking520 merged commit 5c933eb into deepjavalibrary:master Aug 31, 2022
@frankfliu frankfliu deleted the dev branch August 31, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants